From: Paul Eggert <eggert@cs.ucla.edu>
Date: Fri, 22 Sep 2023 16:49:41 +0000 (-0700)
Subject: sort: not a special case for mbrtowc
X-Git-Tag: v9.5~149
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=fc1822a04284862ae63993b4d597ff2f30c2bb24;p=thirdparty%2Fcoreutils.git

sort: not a special case for mbrtowc

* configure.ac (GNULIB_MBRTOWC_SINGLE_THREAD): Define.
---

diff --git a/configure.ac b/configure.ac
index a3e5b22016..eec1107906 100644
--- a/configure.ac
+++ b/configure.ac
@@ -70,11 +70,11 @@ AC_DEFINE([GNULIB_EXCLUDE_SINGLE_THREAD], [1],
   [Define to 1 if apps call 'exclude' functions from a single thread.])
 AC_DEFINE([GNULIB_REGEX_SINGLE_THREAD], [1],
   [Define to 1 if apps call 'regex' functions from a single thread.])
-# This is unsafe, since 'sort' uses mbrtowc indirectly, possibly from
-# multiple threads.
-# AC_DEFINE([GNULIB_MBRTOWC_SINGLE_THREAD], [1],
-#   [Define to 1 if apps call mbrtowc, mbrtoc32, and 'regex' functions
-#    from a single thread.])
+# Although 'sort' is multithreaded and can use these functions,
+# it uses them only from the main thread.
+AC_DEFINE([GNULIB_MBRTOWC_SINGLE_THREAD], [1],
+  [Define to 1 if apps call mbrtowc, mbrtoc32, and 'regex' functions
+   from a single thread.])
 # This is safe, since all apps set locale early.
 AC_DEFINE([GNULIB_WCHAR_SINGLE_LOCALE], [1],
   [Define to 1 if apps don't set the locale after calling