From: Greg Hudson <ghudson@mit.edu>
Date: Wed, 9 Jan 2013 15:07:27 +0000 (-0500)
Subject: Fix void pointer arithmetic in oid_ops.c
X-Git-Tag: krb5-1.12-alpha1~369
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=fc20ae13f18260930433d6239554f24bb50312a3;p=thirdparty%2Fkrb5.git

Fix void pointer arithmetic in oid_ops.c

When asserting that out has advanced the expected number of bytes in
generic_gss_str_to_oid, avoid adding to oid->elements, which is a void
pointer.  Instead subtract from out and compare.

ticket: 7524
---

diff --git a/src/lib/gssapi/generic/oid_ops.c b/src/lib/gssapi/generic/oid_ops.c
index a088734905..a03b6f8da2 100644
--- a/src/lib/gssapi/generic/oid_ops.c
+++ b/src/lib/gssapi/generic/oid_ops.c
@@ -406,7 +406,7 @@ generic_gss_str_to_oid(OM_uint32 *minor_status,
     p = arc3_start;
     while (get_arc(&p, end, &arc))
         arc_encode(arc, &out);
-    assert(out == oid->elements + nbytes);
+    assert(out - nbytes == oid->elements);
     *oid_out = oid;
     return(GSS_S_COMPLETE);
 }