From: Razvan Becheriu <razvan@isc.org>
Date: Fri, 17 Apr 2020 14:26:48 +0000 (+0300)
Subject: [#1142] added comments
X-Git-Tag: Kea-1.7.7~38
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=fc3dd91c60e7a061a881135dc7f55a0d54bc2cc9;p=thirdparty%2Fkea.git

[#1142] added comments
---

diff --git a/src/bin/keactrl/keactrl.in b/src/bin/keactrl/keactrl.in
index 4422b9955b..976f0f3dc3 100644
--- a/src/bin/keactrl/keactrl.in
+++ b/src/bin/keactrl/keactrl.in
@@ -95,7 +95,7 @@ get_pid_from_file() {
         ;;
     esac
 
-    # Extract the name portion of the config file
+    # Extract the name portion (from last slash to last dot) of the config file name
     local conf_name
     conf_name=$(basename -- "${kea_config_file}" | rev | cut -f2- -d'.' | rev)
 
diff --git a/src/bin/keactrl/tests/keactrl_tests.sh.in b/src/bin/keactrl/tests/keactrl_tests.sh.in
index 2265193e6e..7e3748c2e0 100644
--- a/src/bin/keactrl/tests/keactrl_tests.sh.in
+++ b/src/bin/keactrl/tests/keactrl_tests.sh.in
@@ -16,6 +16,8 @@ keactrl=@abs_top_builddir@/src/bin/keactrl/keactrl
 @HAVE_SYSREPO_FALSE@have_netconf=0
 @HAVE_SYSREPO_TRUE@have_netconf=1
 
+# Configuration file names need to have two '.' to check proper extension detection.
+# This is why the names contain '.conf' followed by the extension which is '.json'
 # Names for DHCPv4
 DHCP4_CFG_FILE_NAME="dhcp4_test_config.conf"
 DHCP4_CFG_FILE=@abs_top_builddir@/src/bin/keactrl/tests/${DHCP4_CFG_FILE_NAME}.json