From: Christian Brauner <christian.brauner@ubuntu.com>
Date: Thu, 7 Dec 2017 14:21:57 +0000 (+0100)
Subject: coverity: #1425889
X-Git-Tag: lxc-2.0.10~496
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=fc87280134061fbfe5bb75dd7662ec82726c49cf;p=thirdparty%2Flxc.git

coverity: #1425889

do not call close on bad file descriptor

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
---

diff --git a/src/lxc/commands.c b/src/lxc/commands.c
index c7b0306ab..b33958100 100644
--- a/src/lxc/commands.c
+++ b/src/lxc/commands.c
@@ -316,7 +316,8 @@ static int lxc_cmd(const char *name, struct lxc_cmd_rr *cmd, int *stopped,
 		*stopped = 1;
 out:
 	if (!stay_connected || ret <= 0)
-		close(client_fd);
+		if (client_fd >= 0)
+			close(client_fd);
 
 	if (stay_connected && ret > 0)
 		cmd->rsp.ret = client_fd;