From: Joseph Sutton <josephsutton@catalyst.net.nz>
Date: Thu, 10 Aug 2023 22:07:55 +0000 (+1200)
Subject: s4:kdc: Make some functions static
X-Git-Tag: tevent-0.16.0~985
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=fc99b903463ce06e55c1a2993ad5a4da809099df;p=thirdparty%2Fsamba.git

s4:kdc: Make some functions static

Signed-off-by: Joseph Sutton <josephsutton@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
---

diff --git a/source4/kdc/pac-glue.c b/source4/kdc/pac-glue.c
index 839bc8d840b..368cd23844d 100644
--- a/source4/kdc/pac-glue.c
+++ b/source4/kdc/pac-glue.c
@@ -743,10 +743,10 @@ bool samba_princ_needs_pac(const struct samba_kdc_entry *skdc_entry)
 	return true;
 }
 
-int samba_client_requested_pac(krb5_context context,
-			       const krb5_const_pac pac,
-			       TALLOC_CTX *mem_ctx,
-			       bool *requested_pac)
+static int samba_client_requested_pac(krb5_context context,
+				      const krb5_const_pac pac,
+				      TALLOC_CTX *mem_ctx,
+				      bool *requested_pac)
 {
 	enum ndr_err_code ndr_err;
 	krb5_data k5pac_attrs_in;
@@ -1507,7 +1507,7 @@ static krb5_error_code samba_get_requester_sid(TALLOC_CTX *mem_ctx,
 }
 
 /* Does a parse and SID check, but no crypto. */
-krb5_error_code samba_kdc_validate_pac_blob(
+static krb5_error_code samba_kdc_validate_pac_blob(
 		krb5_context context,
 		const struct samba_kdc_entry *client_skdc_entry,
 		const krb5_const_pac pac)
@@ -1579,10 +1579,10 @@ out:
  * In the RODC case, to confirm that the returned user is permitted to
  * be replicated to the KDC (krbgtgt_xxx user) represented by *rodc
  */
-WERROR samba_rodc_confirm_user_is_allowed(uint32_t num_object_sids,
-					  const struct dom_sid *object_sids,
-					  const struct samba_kdc_entry *rodc,
-					  const struct samba_kdc_entry *object)
+static WERROR samba_rodc_confirm_user_is_allowed(uint32_t num_object_sids,
+						 const struct dom_sid *object_sids,
+						 const struct samba_kdc_entry *rodc,
+						 const struct samba_kdc_entry *object)
 {
 	int ret;
 	WERROR werr;
diff --git a/source4/kdc/pac-glue.h b/source4/kdc/pac-glue.h
index a3f7f8ce421..06bf69433da 100644
--- a/source4/kdc/pac-glue.h
+++ b/source4/kdc/pac-glue.h
@@ -78,11 +78,6 @@ krb5_error_code samba_make_krb5_pac(krb5_context context,
 
 bool samba_princ_needs_pac(const struct samba_kdc_entry *skdc_entry);
 
-int samba_client_requested_pac(krb5_context context,
-			       krb5_const_pac pac,
-			       TALLOC_CTX *mem_ctx,
-			       bool *requested_pac);
-
 int samba_krbtgt_is_in_db(struct samba_kdc_entry *skdc_entry,
 			  bool *is_in_db,
 			  bool *is_trusted);
@@ -105,21 +100,6 @@ NTSTATUS samba_kdc_check_client_access(struct samba_kdc_entry *kdc_entry,
 				       const char *workstation,
 				       bool password_change);
 
-krb5_error_code samba_kdc_validate_pac_blob(
-		krb5_context context,
-		const struct samba_kdc_entry *client_skdc_entry,
-		krb5_const_pac pac);
-
-/*
- * In the RODC case, to confirm that the returned user is permitted to
- * be replicated to the KDC (krbgtgt_xxx user) represented by *rodc
- */
-struct dom_sid;
-WERROR samba_rodc_confirm_user_is_allowed(uint32_t num_sids,
-					  const struct dom_sid *object_sids,
-					  const struct samba_kdc_entry *rodc,
-					  const struct samba_kdc_entry *object);
-
 krb5_error_code samba_kdc_verify_pac(TALLOC_CTX *mem_ctx,
 				     krb5_context context,
 				     uint32_t flags,