From: Noel Power <noel.power@suse.com>
Date: Wed, 14 Aug 2019 13:49:51 +0000 (+0100)
Subject: s3/libsmb: clang: Fix '2nd func call argument is uninitalized value'
X-Git-Tag: tevent-0.10.1~128
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=fcb0355a74ea1c5e446c8465dd2fb017970d408e;p=thirdparty%2Fsamba.git

s3/libsmb: clang: Fix '2nd func call argument is uninitalized value'

Fixes:

source3/libsmb/clireadwrite.c:805:2: warning: 2nd function call argument is an uninitialized value <--[clang]
        memcpy(state->buf, buf, received);
        ^                  ~~~

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
---

diff --git a/source3/libsmb/clireadwrite.c b/source3/libsmb/clireadwrite.c
index 5ee202ebf4e..082febf49cc 100644
--- a/source3/libsmb/clireadwrite.c
+++ b/source3/libsmb/clireadwrite.c
@@ -781,7 +781,7 @@ static void cli_read_done(struct tevent_req *subreq)
 		req, struct cli_read_state);
 	NTSTATUS status;
 	ssize_t received;
-	uint8_t *buf;
+	uint8_t *buf = NULL;
 
 	if (smbXcli_conn_protocol(state->cli->conn) >= PROTOCOL_SMB2_02) {
 		status = cli_smb2_read_recv(subreq, &received, &buf);
@@ -796,7 +796,7 @@ static void cli_read_done(struct tevent_req *subreq)
 	if (tevent_req_nterror(req, status)) {
 		return;
 	}
-	if ((received < 0) || (received > state->buflen)) {
+	if ((buf == NULL) || (received < 0) || (received > state->buflen)) {
 		state->received = 0;
 		tevent_req_nterror(req, NT_STATUS_UNEXPECTED_IO_ERROR);
 		return;