From: Matt Merhar <mattmerhar@protonmail.com>
Date: Wed, 11 Feb 2026 19:33:15 +0000 (-0500)
Subject: build: propagate errors when generating apk indexes
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=fcb07b00ec22b90fc0cd790701982018ee345366;p=thirdparty%2Fopenwrt.git

build: propagate errors when generating apk indexes

The build would continue even if the some of the intermediate commands
failed, as long as the last command in the final iteration of the loop
was successful.

Add 'set -e' to the subshell so that we immediately exit. Previously,
only the exit status of the final make-index-json.py mattered.

Fixes: https://github.com/openwrt/openwrt/issues/21981
Signed-off-by: Matt Merhar <mattmerhar@protonmail.com>
Link: https://github.com/openwrt/openwrt/pull/21993
Signed-off-by: Robert Marko <robimarko@gmail.com>
---

diff --git a/package/Makefile b/package/Makefile
index 7e69b9a0b53..b5581f9859d 100644
--- a/package/Makefile
+++ b/package/Makefile
@@ -129,6 +129,7 @@ $(curdir)/index: FORCE
 	@echo Generating package index...
 ifneq ($(CONFIG_USE_APK),)
 	@for d in $(PACKAGE_SUBDIRS); do \
+		set -e; \
 		mkdir -p $$d; \
 		cd $$d || continue; \
 		ls *.apk >/dev/null 2>&1 || continue; \