From: Ondrej Zajicek (work) <santiago@crfreenet.org>
Date: Sun, 27 Feb 2022 02:10:38 +0000 (+0100)
Subject: Babel: Fix bug in iface reconfiguration
X-Git-Tag: v2.0.10~20
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=fcb4dd0c831339c4374ace17d8f2ae6ebfeed279;p=thirdparty%2Fbird.git

Babel: Fix bug in iface reconfiguration

A recent change in Babel causes ifaces to disappear after
reconfiguration. The patch fixes that.

Thanks to Johannes Kimmel for an insightful bugreport.
---

diff --git a/proto/babel/babel.c b/proto/babel/babel.c
index e43818f50..174fc9e26 100644
--- a/proto/babel/babel.c
+++ b/proto/babel/babel.c
@@ -1899,7 +1899,7 @@ babel_reconfigure_ifaces(struct babel_proto *p, struct babel_config *cf)
     struct babel_iface *ifa = babel_find_iface(p, iface);
     struct babel_iface_config *ic = (void *) iface_patt_find(&cf->iface_list, iface, NULL);
 
-    if (ic && iface_is_valid(p, iface))
+    if (ic && !iface_is_valid(p, iface))
       ic = NULL;
 
     if (ifa && ic)