From: Ján Tomko <jtomko@redhat.com>
Date: Tue, 28 Mar 2017 07:45:10 +0000 (+0200)
Subject: Revert "storage: Better describe logical pool creation/definition parameters"
X-Git-Tag: v3.2.0-rc2~11
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=fcb90d72abda952e79546935ae5253d0e01c49a4;p=thirdparty%2Flibvirt.git

Revert "storage: Better describe logical pool creation/definition parameters"

This reverts commit ca4515d2639057020c749470f390fe1f5981e91e
which also included a functional change that broke logical storage pools
not named after their volume groups.
---

diff --git a/src/conf/storage_conf.c b/src/conf/storage_conf.c
index 5213503c2e..585ca71aaf 100644
--- a/src/conf/storage_conf.c
+++ b/src/conf/storage_conf.c
@@ -760,14 +760,6 @@ virStoragePoolDefParseXML(xmlXPathContextPtr ctxt)
             if (VIR_STRDUP(ret->source.name, ret->name) < 0)
                 goto error;
         }
-        if (ret->type == VIR_STORAGE_POOL_LOGICAL &&
-            STRNEQ(ret->name, ret->source.name)) {
-                virReportError(VIR_ERR_XML_ERROR,
-                               _("for a logical pool, the pool name='%s' "
-                                 "must match the pool source name='%s'"),
-                               ret->name, ret->source.name);
-                goto error;
-        }
     }
 
     if ((options->flags & VIR_STORAGE_POOL_SOURCE_ADAPTER) &&
diff --git a/tools/virsh.pod b/tools/virsh.pod
index 55b71a9b9f..43124ba558 100644
--- a/tools/virsh.pod
+++ b/tools/virsh.pod
@@ -3639,13 +3639,6 @@ follow-up command to build the pool. The I<--overwrite> and
 I<--no-overwrite> flags follow the same rules as B<pool-build>. If
 just I<--build> is provided, then B<pool-build> is called with no flags.
 
-For a "logical" pool only [I<--name>] needs to be provided. The [I<--name>]
-must match the Volume Group name for which the pool is being defined or
-created. The [I<--source-name>] if provided must match the Volume Group
-name. If not provided, one will be generated using the [I<--name>]. If
-provided the [I<--target>] is ignored and a target source is generated
-using the [I<--source-name>] (or as generated from the [I<--name>]).
-
 =item B<pool-define> I<file>
 
 Define an inactive persistent storage pool or modify an existing persistent one