From: Matthias Dieter Wallnöfer <mwallnoefer@yahoo.de>
Date: Fri, 19 Sep 2008 10:39:53 +0000 (+0200)
Subject: Registry server LDB backend REG_BINARY type: Save it directly in LDB
X-Git-Tag: samba-4.0.0alpha6~780
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=fcc93f68a0d87d3f938bdd6ecd6dc91c6ab648d5;p=thirdparty%2Fsamba.git

Registry server LDB backend REG_BINARY type: Save it directly in LDB

With this patch the REG_BINARY type is saved directly in a LDB registry database rather than converted in a hex-string.
---

diff --git a/source4/lib/registry/ldb.c b/source4/lib/registry/ldb.c
index 53ec076db3f..6c7c448b3d4 100644
--- a/source4/lib/registry/ldb.c
+++ b/source4/lib/registry/ldb.c
@@ -72,7 +72,7 @@ static void reg_ldb_unpack_value(TALLOC_CTX *mem_ctx,
 
 	case REG_BINARY:
 		if (val != NULL)
-			*data = strhex_to_data_blob((char *)val->data);
+			*data = data_blob_talloc(mem_ctx, val->data, val->length);
 		else {
 			data->data = NULL;
 			data->length = 0;
@@ -117,8 +117,10 @@ static struct ldb_message *reg_ldb_pack_value(struct ldb_context *ctx,
 		break;
 
 	case REG_BINARY:
-		ldb_msg_add_string(msg, "data",
-				   data_blob_hex_string(mem_ctx, &data));
+		if (data.length > 0)
+			ldb_msg_add_value(msg, "data", &data, NULL);
+		else
+			ldb_msg_add_empty(msg, "data", LDB_FLAG_MOD_DELETE, NULL);
 		break;
 
 	case REG_DWORD: