From: Peter Krempa <pkrempa@redhat.com>
Date: Tue, 25 Feb 2025 11:34:39 +0000 (+0100)
Subject: virXMLNodeGetSubelementList: Document return value semantics
X-Git-Tag: v11.2.0-rc1~170
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=fcd47086f42405639569d5513bf5e4938591fb42;p=thirdparty%2Flibvirt.git

virXMLNodeGetSubelementList: Document return value semantics

The returned value is always non-NULL. Callers need to check the length
of the returned array instead.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
---

diff --git a/src/util/virxml.c b/src/util/virxml.c
index 06e698cdf8..ad967a2564 100644
--- a/src/util/virxml.c
+++ b/src/util/virxml.c
@@ -909,6 +909,8 @@ virXMLNodeGetSubelement(xmlNodePtr node,
  * Find and return a sub-elements node of @node named @name in a GPtrArray
  * populated with the xmlNodePtr objects. Caller is responsible for freeing the
  * array but not the contained xmlNode objects.
+ *
+ * Note: The returned GPtrArray is non-NULL even if @node doesn't contain such sub-elements
  */
 GPtrArray *
 virXMLNodeGetSubelementList(xmlNodePtr node,