From: Volker Lendecke <vl@samba.org>
Date: Fri, 22 Jan 2021 19:01:27 +0000 (+0100)
Subject: librpc: Simplify dcerpc_binding_set_abstract_syntax()
X-Git-Tag: tevent-0.11.0~1883
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=fcf60f155a24bea97395b7ee0200543440782a74;p=thirdparty%2Fsamba.git

librpc: Simplify dcerpc_binding_set_abstract_syntax()

It might be a question of style, but I find it simpler this way.

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Samuel Cabrero <scabrero@samba.org>
---

diff --git a/librpc/rpc/binding.c b/librpc/rpc/binding.c
index 57ceed012f4..d4ca43e8066 100644
--- a/librpc/rpc/binding.c
+++ b/librpc/rpc/binding.c
@@ -652,20 +652,12 @@ _PUBLIC_ NTSTATUS dcerpc_binding_set_abstract_syntax(struct dcerpc_binding *b,
 
 	if (syntax == NULL) {
 		status = dcerpc_binding_set_string_option(b, "abstract_syntax", NULL);
-		if (!NT_STATUS_IS_OK(status)) {
-			return status;
-		}
-
-		return NT_STATUS_OK;
+		return status;
 	}
 
 	if (ndr_syntax_id_equal(&ndr_syntax_id_null, syntax)) {
 		status = dcerpc_binding_set_string_option(b, "abstract_syntax", NULL);
-		if (!NT_STATUS_IS_OK(status)) {
-			return status;
-		}
-
-		return NT_STATUS_OK;
+		return status;
 	}
 
 	status = dcerpc_binding_set_string_option(