From: Osier Yang <jyang@redhat.com>
Date: Wed, 2 May 2012 14:51:38 +0000 (+0800)
Subject: Coverity: Fix resource leak in virnetlink.c
X-Git-Tag: v0.9.12-rc2~33
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=fd2b41574e05510ddeffbf9acbf06584acb3c2b2;p=thirdparty%2Flibvirt.git

Coverity: Fix resource leak in virnetlink.c
---

diff --git a/src/util/virnetlink.c b/src/util/virnetlink.c
index 74f43ac3a0..e609494ffc 100644
--- a/src/util/virnetlink.c
+++ b/src/util/virnetlink.c
@@ -347,11 +347,13 @@ virNetlinkEventServiceStart(void)
 
     if (VIR_ALLOC(srv) < 0) {
         virReportOOMError();
-        goto error;
+        return -1;
     }
 
-    if (virMutexInit(&srv->lock) < 0)
-        goto error;
+    if (virMutexInit(&srv->lock) < 0) {
+        VIR_FREE(srv);
+        return -1;
+    }
 
     virNetlinkEventServerLock(srv);
 
@@ -410,7 +412,6 @@ error_locked:
         virMutexDestroy(&srv->lock);
         VIR_FREE(srv);
     }
-error:
     return ret;
 }