From: Andrew Tridgell <tridge@samba.org>
Date: Fri, 11 Sep 2009 11:45:35 +0000 (+1000)
Subject: s4-repl: don't update replPropertyMetaData for non-replicated attributes
X-Git-Tag: talloc-2.0.1~527^2~1
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=fd3a77839cf747ce884cbd4e1cc212f22c4836a2;p=thirdparty%2Fsamba.git

s4-repl: don't update replPropertyMetaData for non-replicated attributes

thanks to Metze for spotting this
---

diff --git a/source4/dsdb/samdb/ldb_modules/repl_meta_data.c b/source4/dsdb/samdb/ldb_modules/repl_meta_data.c
index c4699366455..bb446333e27 100644
--- a/source4/dsdb/samdb/ldb_modules/repl_meta_data.c
+++ b/source4/dsdb/samdb/ldb_modules/repl_meta_data.c
@@ -491,6 +491,13 @@ static int replmd_update_rpmd_element(struct ldb_context *ldb,
 		return LDB_ERR_OPERATIONS_ERROR;
 	}
 
+	if ((a->systemFlags & 0x00000001) || (a->systemFlags & 0x00000004)) {
+		/* if the attribute is not replicated (0x00000001)
+		 * or constructed (0x00000004) it has no metadata
+		 */
+		return LDB_SUCCESS;
+	}
+
 	for (i=0; i<omd->ctr.ctr1.count; i++) {
 		if (a->attributeID_id == omd->ctr.ctr1.array[i].attid) break;
 	}