From: Ryan Moeller <ryan@ixsystems.com>
Date: Mon, 24 Feb 2020 06:46:15 +0000 (-0500)
Subject: bhyve: process: don't bother seeking to end of log
X-Git-Tag: v6.1.0-rc1~45
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=fd54da1ef25b6d0f193245c221ab33258912a692;p=thirdparty%2Flibvirt.git

bhyve: process: don't bother seeking to end of log

The file is opened O_APPEND.

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Signed-off-by: Ryan Moeller <ryan@iXsystems.com>
---

diff --git a/src/bhyve/bhyve_process.c b/src/bhyve/bhyve_process.c
index b0b428eeb4..a11f75a894 100644
--- a/src/bhyve/bhyve_process.c
+++ b/src/bhyve/bhyve_process.c
@@ -101,8 +101,6 @@ virBhyveProcessStart(virConnectPtr conn,
     char *devicemap = NULL;
     char *logfile = NULL;
     int logfd = -1;
-    off_t pos = -1;
-    char ebuf[1024];
     virCommandPtr cmd = NULL;
     virCommandPtr load_cmd = NULL;
     bhyveConnPtr driver = conn->privateData;
@@ -172,9 +170,6 @@ virBhyveProcessStart(virConnectPtr conn,
 
         /* Log generated command line */
         virCommandWriteArgLog(load_cmd, logfd);
-        if ((pos = lseek(logfd, 0, SEEK_END)) < 0)
-            VIR_WARN("Unable to seek to end of logfile: %s",
-                     virStrerror(errno, ebuf, sizeof(ebuf)));
 
         VIR_DEBUG("Loading domain '%s'", vm->def->name);
         if (virCommandRun(load_cmd, NULL) < 0)