From: Harlan Stenn <stenn@ntp.org>
Date: Mon, 19 Aug 2013 03:00:37 +0000 (-0400)
Subject: CID 1009579: Check return status of X509_add_ext()
X-Git-Tag: NTP_4_2_7P385~3
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=fd6fa1cb5def3b7ffbe18832e13a7fa012d1de80;p=thirdparty%2Fntp.git

CID 1009579: Check return status of X509_add_ext()

bk: 52118a55HBLFBDXN8jxlpsTR45dYVg
---

diff --git a/ChangeLog b/ChangeLog
index d2d999c32..7469a7948 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,4 @@
+* CID 1009579: Check return status of X509_add_ext().
 * [2085] Fix root distance and root dispersion calculations.
 (4.2.7p384) 2013/08/18 Released by Harlan Stenn <stenn@ntp.org>
 * [Bug 2450] --version has bogus short option.
diff --git a/ntpd/ntp_crypto.c b/ntpd/ntp_crypto.c
index 6c6734763..f4d1f496a 100644
--- a/ntpd/ntp_crypto.c
+++ b/ntpd/ntp_crypto.c
@@ -2992,7 +2992,7 @@ cert_sign(
 	temp = X509_get_ext_count(req);
 	for (i = 0; i < temp; i++) {
 		ext = X509_get_ext(req, i);
-		X509_add_ext(cert, ext, -1);
+		INSIST(X509_add_ext(cert, ext, -1));
 	}
 	X509_free(req);