From: Christian Brauner Date: Fri, 3 Sep 2021 09:04:58 +0000 (+0200) Subject: commands: fix integer comparisons X-Git-Tag: lxc-5.0.0~92^2~47 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=fd80f8c0fd52998f9e8ee338d2be9e9bd1ea665a;p=thirdparty%2Flxc.git commands: fix integer comparisons Signed-off-by: Christian Brauner --- diff --git a/src/lxc/commands.c b/src/lxc/commands.c index 535242f10..4c2f77ada 100644 --- a/src/lxc/commands.c +++ b/src/lxc/commands.c @@ -253,14 +253,14 @@ static ssize_t lxc_cmd_rsp_recv(int sock, struct lxc_cmd_rr *cmd) case LXC_CMD_GET_CGROUP_FD: /* data */ __fallthrough; case LXC_CMD_GET_LIMIT_CGROUP_FD: /* data */ - if (rsp->datalen > sizeof(struct cgroup_fd)) + if ((size_t)rsp->datalen > sizeof(struct cgroup_fd)) return syserror_set(-EINVAL, "Invalid response size from server for \"%s\"", cur_cmdstr); /* Don't pointlessly allocate. */ rsp->data = (void *)cmd->req.data; break; case LXC_CMD_GET_CGROUP_CTX: /* data */ - if (rsp->datalen > sizeof(struct cgroup_ctx)) + if ((size_t)rsp->datalen > sizeof(struct cgroup_ctx)) return syserror_set(-EINVAL, "Invalid response size from server for \"%s\"", cur_cmdstr); /* Don't pointlessly allocate. */ @@ -1489,7 +1489,7 @@ static int lxc_cmd_console_log_callback(int fd, struct lxc_cmd_req *req, if (log->read) rsp.data = lxc_ringbuf_get_read_addr(buf); - if (log->read_max > 0 && (log->read_max <= rsp.datalen)) + if (log->read_max > 0 && (log->read_max <= (uint64_t)rsp.datalen)) rsp.datalen = log->read_max; /* there's nothing to read */