From: Zhen Ni Date: Fri, 19 Dec 2025 07:36:49 +0000 (+0800) Subject: btrfs: simplify check for zoned NODATASUM writes in btrfs_submit_chunk() X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=fdb945f6659374c9628509517901d49035b0e984;p=thirdparty%2Fkernel%2Flinux.git btrfs: simplify check for zoned NODATASUM writes in btrfs_submit_chunk() This function already dereferences 'inode' multiple times earlier, making the additional NULL check at line 840 redundant since the function would have crashed already if inode were NULL. After commit 81cea6cd7041 ("btrfs: remove btrfs_bio::fs_info by extracting it from btrfs_bio::inode"), the btrfs_bio::inode field is mandatory for all btrfs_bio allocations and is guaranteed to be non-NULL. Simplify the condition for allocating dummy checksums for zoned NODATASUM data by removing the unnecessary 'inode &&' check. Reviewed-by: Johannes Thumshirn Signed-off-by: Zhen Ni Reviewed-by: David Sterba Signed-off-by: David Sterba --- diff --git a/fs/btrfs/bio.c b/fs/btrfs/bio.c index e4d382d3a7aea..a12446aa0fbf7 100644 --- a/fs/btrfs/bio.c +++ b/fs/btrfs/bio.c @@ -836,8 +836,7 @@ static bool btrfs_submit_chunk(struct btrfs_bio *bbio, int mirror_num) if (status) goto fail; } else if (bbio->can_use_append || - (btrfs_is_zoned(fs_info) && inode && - inode->flags & BTRFS_INODE_NODATASUM)) { + (btrfs_is_zoned(fs_info) && inode->flags & BTRFS_INODE_NODATASUM)) { ret = btrfs_alloc_dummy_sum(bbio); status = errno_to_blk_status(ret); if (status)