From: Bradley Nicholes <bnicholes@apache.org>
Date: Mon, 29 Mar 2004 22:07:48 +0000 (+0000)
Subject: Fixed the truncated parameters when envoking a CGI program on NetWare
X-Git-Tag: 2.0.50~264
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=fdbd1f41bc589a7596c22538ce4c1fc940e5973e;p=thirdparty%2Fapache%2Fhttpd.git

Fixed the truncated parameters when envoking a CGI program on NetWare


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/branches/APACHE_2_0_BRANCH@103201 13f79535-47bb-0310-9956-ffa450edef68
---

diff --git a/modules/arch/netware/mod_netware.c b/modules/arch/netware/mod_netware.c
index 14404577455..56f105a1092 100644
--- a/modules/arch/netware/mod_netware.c
+++ b/modules/arch/netware/mod_netware.c
@@ -98,6 +98,7 @@ static apr_status_t ap_cgi_build_command(const char **cmd, const char ***argv,
 {
     char *ext = NULL;
     char *cmd_only, *ptr;
+    const char *new_cmd;
     const char *detached = NULL;
     netware_dir_config *d;
     apr_file_t *fh;
@@ -140,20 +141,16 @@ static apr_status_t ap_cgi_build_command(const char **cmd, const char ***argv,
         ++ext;
 
     /* check if we have a registered command for the extension*/
-    *cmd = apr_table_get(d->file_type_handlers, ext);
-    if (*cmd == NULL) {
+    new_cmd = apr_table_get(d->file_type_handlers, ext);
+    if (new_cmd == NULL) {
         ap_log_rerror(APLOG_MARK, APLOG_ERR, 0, r,
                   "Could not find a command associated with the %s extension", ext);
         return APR_EBADF;
     }
-    if (!stricmp(*cmd, "OS")) {
-        /* If it is an NLM then restore *cmd and just execute it */
-        *cmd = cmd_only;
-    }
-    else {
+    if (stricmp(new_cmd, "OS")) {
         /* If we have a registered command then add the file that was passed in as a
           parameter to the registered command. */
-        *cmd = apr_pstrcat (p, *cmd, " ", cmd_only, NULL);
+        *cmd = apr_pstrcat (p, new_cmd, " ", cmd_only, NULL);
 
         /* Run in its own address space if specified */
         detached = apr_table_get(d->file_handler_mode, ext);