From: Christoph Grüninger <foss@grueninger.de>
Date: Wed, 14 May 2025 19:21:31 +0000 (+0200)
Subject: rules.c: Simplify if condition
X-Git-Tag: 0.7.33~4^2~2
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=fdbfb3fee01491f91927e700728a888b76ab31c5;p=thirdparty%2Flibsolv.git

rules.c: Simplify if condition

rid <=0 is checked two lines before.
Found by Cppcheck (knownConditionTrueFalse).
---

diff --git a/src/rules.c b/src/rules.c
index cb3f9a32..6b1dc037 100644
--- a/src/rules.c
+++ b/src/rules.c
@@ -3206,7 +3206,7 @@ solver_ruleclass(Solver *solv, Id rid)
 {
   if (rid <= 0)
     return SOLVER_RULE_UNKNOWN;
-  if (rid > 0 && rid < solv->pkgrules_end)
+  if (rid < solv->pkgrules_end)
     return SOLVER_RULE_PKG;
   if (rid >= solv->jobrules && rid < solv->jobrules_end)
     return SOLVER_RULE_JOB;