From: Peter Krempa <pkrempa@redhat.com>
Date: Tue, 9 Nov 2021 12:29:43 +0000 (+0100)
Subject: qemuDiskSourceGetProps: Initialize 'ret'
X-Git-Tag: v7.10.0-rc1~118
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=fdda016bceee5b47f33a5c223a88c6fce394ea70;p=thirdparty%2Flibvirt.git

qemuDiskSourceGetProps: Initialize 'ret'

Upcomming patch will convert virJSONValueObjectCreate which didn't check
the value of the passed argument to virJSONValueObjectAdd which will and
this would lead to crashes.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
---

diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c
index 17ff7a5fe2..e63e82e261 100644
--- a/src/qemu/qemu_command.c
+++ b/src/qemu/qemu_command.c
@@ -1616,7 +1616,7 @@ static virJSONValue *
 qemuDiskSourceGetProps(virStorageSource *src)
 {
     g_autoptr(virJSONValue) props = NULL;
-    virJSONValue *ret;
+    virJSONValue *ret = NULL;
 
     if (!(props = qemuBlockStorageSourceGetBackendProps(src,
                                                         QEMU_BLOCK_STORAGE_SOURCE_BACKEND_PROPS_LEGACY)))