From: Bartel Artem <artem.bartel@gmail.com>
Date: Mon, 25 Nov 2024 11:28:05 +0000 (+0300)
Subject: apps/passwd.c: Convert a redundant check to assert
X-Git-Tag: openssl-3.5.0-alpha1~866
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=fdded23b4481449edd8972fd60265a9f33e43e22;p=thirdparty%2Fopenssl.git

apps/passwd.c: Convert a redundant check to assert

Reviewed-by: Tom Cosgrove <tom.cosgrove@arm.com>
Reviewed-by: Paul Yang <kaishen.yy@antfin.com>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/26053)
---

diff --git a/apps/passwd.c b/apps/passwd.c
index 31c7077ccc4..8b233538d87 100644
--- a/apps/passwd.c
+++ b/apps/passwd.c
@@ -369,8 +369,7 @@ static char *md5crypt(const char *passwd, const char *magic, const char *salt)
     if (magic_len > 0)
         salt_out += 2 + magic_len;
 
-    if (salt_len > 8)
-        goto err;
+    assert(salt_len <= 8);
 
     md = EVP_MD_CTX_new();
     if (md == NULL