From: lpsolit%gmail.com <>
Date: Wed, 21 Jan 2009 10:51:01 +0000 (+0000)
Subject: Bug 471633: Sort open bugs and closed bugs separately in show_bug dependson/blocks... 
X-Git-Tag: bugzilla-3.3.2~37
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=fdfe948ab5eea11a0ce98b84044308a6f95adfa0;p=thirdparty%2Fbugzilla.git

Bug 471633: Sort open bugs and closed bugs separately in show_bug dependson/blocks lists - Patch by Nitish Bezzala <nbezzala@yahoo.com> r/a=LpSolit
---

diff --git a/Bugzilla/Bug.pm b/Bugzilla/Bug.pm
index d941a766e1..0b4e6e7943 100644
--- a/Bugzilla/Bug.pm
+++ b/Bugzilla/Bug.pm
@@ -2800,12 +2800,18 @@ sub editable_bug_fields {
 
 # XXX - When Bug::update() will be implemented, we should make this routine
 #       a private method.
+# Join with bug_status and bugs tables to show bugs with open statuses first,
+# and then the others
 sub EmitDependList {
     my ($myfield, $targetfield, $bug_id) = (@_);
     my $dbh = Bugzilla->dbh;
     my $list_ref = $dbh->selectcol_arrayref(
-          "SELECT $targetfield FROM dependencies
-            WHERE $myfield = ? ORDER BY $targetfield",
+          "SELECT $targetfield
+             FROM dependencies
+                  INNER JOIN bugs ON dependencies.$targetfield = bugs.bug_id
+                  INNER JOIN bug_status ON bugs.bug_status = bug_status.value
+            WHERE $myfield = ?
+            ORDER BY is_open DESC, $targetfield",
             undef, $bug_id);
     return $list_ref;
 }