From: Marc-André Lureau <marcandre.lureau@redhat.com>
Date: Wed, 5 Jun 2019 10:31:01 +0000 (+0200)
Subject: qemu_firmware: only set nfeatures on success
X-Git-Tag: v5.5.0-rc1~17
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=fe09cd72aa8ad0bedeee68158190b334c5bca775;p=thirdparty%2Flibvirt.git

qemu_firmware: only set nfeatures on success

The field is set just before returning on success.

Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
Signed-off-by: Ján Tomko <jtomko@redhat.com>
---

diff --git a/src/qemu/qemu_firmware.c b/src/qemu/qemu_firmware.c
index f3d89d000d..bf29b10b9a 100644
--- a/src/qemu/qemu_firmware.c
+++ b/src/qemu/qemu_firmware.c
@@ -592,8 +592,6 @@ qemuFirmwareFeatureParse(const char *path,
     if (VIR_ALLOC_N(features, nfeatures) < 0)
         return -1;
 
-    fw->nfeatures = nfeatures;
-
     for (i = 0; i < nfeatures; i++) {
         virJSONValuePtr item = virJSONValueArrayGet(featuresJSON, i);
         const char *tmpStr = virJSONValueGetString(item);