From: Jeff Peeler <jpeeler@digium.com>
Date: Fri, 12 Nov 2010 20:49:09 +0000 (+0000)
Subject: Fix regression causing abort in voicemail after opening a mailbox with no mesgs.
X-Git-Tag: 1.4.38-rc1~9
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=fe1ca1a8da44772170e815b851f7ea57bd557c0a;p=thirdparty%2Fasterisk.git

Fix regression causing abort in voicemail after opening a mailbox with no mesgs.

In order to be more safe, some error handling code was changed to respect more
error conditions including the potential memory allocation failure for deleted
and heard message tracking introduced in 293004. However, last_message_index
returns -1 for zero messages (perhaps as expected) and was triggering the
stricter error checking. Because last_message_index is only called directly
in one place, just return 0 from open_mailbox (for file based storage) when no
messages are detected unless a real error has occurred.

(closes issue #18240)
Reported by: leobrown
Patches:
      bug18240.1-6-2.diff.txt uploaded by alecdavis (license 585)
Tested by: pabelanger


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@294903 65c4cc65-6c06-0410-ace0-fbb531ad65f3
---

diff --git a/apps/app_voicemail.c b/apps/app_voicemail.c
index 6f6a932863..dca093d43d 100644
--- a/apps/app_voicemail.c
+++ b/apps/app_voicemail.c
@@ -1744,6 +1744,7 @@ static int open_mailbox(struct vm_state *vms, struct ast_vm_user *vmu, int box)
 		ast_log(LOG_WARNING, "The code expects the old messages to be checked first, fix the code.\n");
 	}
 	if (vm_allocate_dh(vms, vmu, box == 0 ? vms->vmArrayIndex + vms->oldmessages : vms->lastmsg)) {
+		ast_mutex_unlock(&vms->lock);
 		return -1;
 	}
 
@@ -5969,7 +5970,7 @@ static int open_mailbox(struct vm_state *vms, struct ast_vm_user *vmu,int box)
 
 	/* for local storage, checks directory for messages up to maxmsg limit */
 	last_msg = last_message_index(vmu, vms->curdir);
-	if (last_msg < 0)
+	if (last_msg < -1)
 		return last_msg;
 	else if (vms->lastmsg != last_msg)
 	{