From: Jeff Trawick <trawick@apache.org>
Date: Wed, 23 Oct 2013 11:59:35 +0000 (+0000)
Subject: don't ignore some apr_procattr failures (clang scan-build)
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=fe9f97b165b0fec9bb56f4a9f7f0a47a998ac674;p=thirdparty%2Fapache%2Fhttpd.git

don't ignore some apr_procattr failures (clang scan-build)

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1534995 13f79535-47bb-0310-9956-ffa450edef68
---

diff --git a/server/log.c b/server/log.c
index ca5450a26ce..a62867e06fc 100644
--- a/server/log.c
+++ b/server/log.c
@@ -276,8 +276,10 @@ static int log_child(apr_pool_t *p, const char *progname,
                 rc = apr_procattr_child_err_set(procattr, errfile, NULL);
         }
 
-        rc = apr_proc_create(procnew, args[0], (const char * const *)args,
-                             NULL, procattr, p);
+        if (rc == APR_SUCCESS) {
+            rc = apr_proc_create(procnew, args[0], (const char * const *)args,
+                                 NULL, procattr, p);
+        }
 
         if (rc == APR_SUCCESS) {
             apr_pool_note_subprocess(p, procnew, APR_KILL_AFTER_TIMEOUT);