From: Tim Wiederhake <twiederh@redhat.com>
Date: Mon, 10 May 2021 12:48:35 +0000 (+0200)
Subject: virNetworkDHCPLeaseTimeDefParseXML: Use virXMLProp*
X-Git-Tag: v7.4.0-rc1~164
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=fee958313d400465adf8426444742324eec39109;p=thirdparty%2Flibvirt.git

virNetworkDHCPLeaseTimeDefParseXML: Use virXMLProp*

Signed-off-by: Tim Wiederhake <twiederh@redhat.com>
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
---

diff --git a/src/conf/network_conf.c b/src/conf/network_conf.c
index c3c335135b..a9eadff29c 100644
--- a/src/conf/network_conf.c
+++ b/src/conf/network_conf.c
@@ -410,27 +410,21 @@ virNetworkDHCPLeaseTimeDefParseXML(virNetworkDHCPLeaseTimeDef **lease,
                                    xmlNodePtr node)
 {
     virNetworkDHCPLeaseTimeDef *new_lease = NULL;
-    g_autofree char *expirystr = NULL;
-    g_autofree char *unitstr = NULL;
     unsigned long long expiry;
-    int unit = VIR_NETWORK_DHCP_LEASETIME_UNIT_MINUTES;
+    virNetworkDHCPLeaseTimeUnitType unit;
+    int rc;
 
-    if (!(expirystr = virXMLPropString(node, "expiry")))
+    if ((rc = virXMLPropULongLong(node, "expiry", 0, VIR_XML_PROP_NONE, &expiry)) < 0)
+        return -1;
+
+    if (rc == 0)
         return 0;
 
-    if (virStrToLong_ull(expirystr, NULL, 10, &expiry) < 0) {
-        virReportError(VIR_ERR_XML_ERROR,
-                       _("failed to parse expiry value '%s'"), expirystr);
+    if (virXMLPropEnumDefault(node, "unit",
+                              virNetworkDHCPLeaseTimeUnitTypeFromString,
+                              VIR_XML_PROP_NONE, &unit,
+                              VIR_NETWORK_DHCP_LEASETIME_UNIT_MINUTES) < 0)
         return -1;
-    }
-
-    if ((unitstr = virXMLPropString(node, "unit"))) {
-        if ((unit = virNetworkDHCPLeaseTimeUnitTypeFromString(unitstr)) < 0) {
-            virReportError(VIR_ERR_XML_ERROR,
-                           _("Invalid unit: %s"), unitstr);
-            return -1;
-        }
-    }
 
     /* infinite */
     if (expiry > 0) {