From: Andrew Bartlett <abartlet@samba.org>
Date: Fri, 16 Aug 2019 02:29:45 +0000 (+1200)
Subject: auth/credentials: Check NTSTATUS return from netlogon_creds_aes_encrypt()
X-Git-Tag: tevent-0.10.1~262
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=fefd95091cc52f5e2655fa392312a8b1fa1d35fd;p=thirdparty%2Fsamba.git

auth/credentials: Check NTSTATUS return from netlogon_creds_aes_encrypt()

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
---

diff --git a/auth/credentials/credentials.c b/auth/credentials/credentials.c
index 5ebec483705..81f9dbb9eb3 100644
--- a/auth/credentials/credentials.c
+++ b/auth/credentials/credentials.c
@@ -1333,19 +1333,19 @@ _PUBLIC_ NTSTATUS netlogon_creds_session_encrypt(
 		return NT_STATUS_INVALID_PARAMETER;
 	}
 	if (state->negotiate_flags & NETLOGON_NEG_SUPPORTS_AES) {
-		netlogon_creds_aes_encrypt(state,
-					   data.data,
-					   data.length);
+		status = netlogon_creds_aes_encrypt(state,
+						    data.data,
+						    data.length);
 	} else if (state->negotiate_flags & NETLOGON_NEG_ARCFOUR) {
 		status = netlogon_creds_arcfour_crypt(state,
 						      data.data,
 						      data.length);
-		if (!NT_STATUS_IS_OK(status)) {
-			return status;
-		}
 	} else {
 		DBG_ERR("Unsupported encryption option negotiated");
-		return NT_STATUS_NOT_SUPPORTED;
+		status = NT_STATUS_NOT_SUPPORTED;
+	}
+	if (!NT_STATUS_IS_OK(status)) {
+		return status;
 	}
 	return NT_STATUS_OK;
 }