From: Arran Cudbard-Bell <a.cudbardb@freeradius.org>
Date: Thu, 25 Jan 2018 03:27:30 +0000 (-0700)
Subject: Don't shallow copy anything...
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=ff08ae6447e9c4cccf8bda2f61ee5ea9c4d1abb6;p=thirdparty%2Ffreeradius-server.git

Don't shallow copy anything...
---

diff --git a/src/modules/rlm_expr/rlm_expr.c b/src/modules/rlm_expr/rlm_expr.c
index 52bc5f269f9..1fa75ac6a9c 100644
--- a/src/modules/rlm_expr/rlm_expr.c
+++ b/src/modules/rlm_expr/rlm_expr.c
@@ -1003,11 +1003,7 @@ static int fr_value_box_from_fmt(fr_value_box_t *out, REQUEST *request, char con
 	 */
 	if ((radius_get_vp(&vp, request, fmt) < 0) || !vp) return -1;
 
-	/*
-	 *	These are large types.  Return pointers to the
-	 *	data instead of copying the data.
-	 */
-	fr_value_box_copy_shallow(NULL, out, &vp->data);
+	fr_value_box_copy(NULL, out, &vp->data);
 
 	return 0;
 }