From: Frédéric Marchal <fmarchal@users.sourceforge.net>
Date: Wed, 1 Feb 2012 10:34:45 +0000 (+0100)
Subject: Remove the obsolete cc option
X-Git-Tag: v2.3.3-pre1~41
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=ff0eb6c5fd13585209296153e2cfbf3315652799;p=thirdparty%2Fsarg.git

Remove the obsolete cc option

If sarg is compiled with cc, the old configure script would add the -Aa
option to the CFLAGS but that option produces an error on modern cc. The
error is about a missing argument. I could not find the new syntax nor the
purpose of that option but it was reported that removing the whole
condition was solving the problem.

Bug report here:

http://sourceforge.net/tracker/?func=detail&aid=3467463&group_id=68910&atid=522791
---

diff --git a/configure.in b/configure.in
index 33aa9d2..a5732e0 100644
--- a/configure.in
+++ b/configure.in
@@ -17,9 +17,13 @@ dnl yes ) CC=g++ ;;
 dnl  *   ) AC_PROG_CXX ;;
 esac
 
-if test "${CC}" = "cc" ; then
-   CFLAGS="${CFLAGS} -g -O2 -Aa"
-fi
+dnl The purpose of the following condition is unknown but it is obsolete as it is.
+dnl The -Aa option produces an error claiming that some argument are missing.
+dnl if test "${CC}" = "cc" ; then
+dnl    CFLAGS="${CFLAGS} -g -O2 -Aa"
+dnl fi
+
+# Report more warnings to improve code quality.
 CFLAGS="${CFLAGS} -Wall -Wno-sign-compare"
 
 dnl Check for supported compiler options