From: Christopher Faulet <cfaulet@haproxy.com>
Date: Mon, 7 Jan 2019 14:03:22 +0000 (+0100)
Subject: BUG/MINOR: filters: Detect cache+compression config on legacy HTTP streams
X-Git-Tag: v2.0-dev1~245
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=ff17b183fe06867b37e9dba286bfa8e69e58f614;p=thirdparty%2Fhaproxy.git

BUG/MINOR: filters: Detect cache+compression config on legacy HTTP streams

On legacy HTTP streams, it is forbidden to use the compression with the
cache. When the compression filter is explicitly specified, the detection works
as expected and such configuration are rejected at startup. But it does not work
when the compression filter is implicitly defined. To fix the bug, the implicit
declaration of the compression filter is checked first, before calling .check()
callback of each filters.

This patch should be backported to 1.9.
---

diff --git a/src/filters.c b/src/filters.c
index 4f3fae7e38..1a7727669b 100644
--- a/src/filters.c
+++ b/src/filters.c
@@ -332,11 +332,11 @@ flt_check(struct proxy *proxy)
 	struct flt_conf *fconf;
 	int err = 0;
 
+	err += check_implicit_http_comp_flt(proxy);
 	list_for_each_entry(fconf, &proxy->filter_configs, list) {
 		if (fconf->ops->check)
 			err += fconf->ops->check(proxy, fconf);
 	}
-	err += check_implicit_http_comp_flt(proxy);
 	return err;
 }