From: Douglas Bagnall Date: Thu, 22 May 2025 22:34:14 +0000 (+1200) Subject: s3:smb2: debug mentions function name fewer times X-Git-Tag: tevent-0.17.0~55 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=ff185e4e0a56bcf981cd724d3056f0023e34b2b3;p=thirdparty%2Fsamba.git s3:smb2: debug mentions function name fewer times There was a complaint about messages like this ../../source3/smbd/smb2_server.c:4058(smbd_smb2_request_error_ex) smbd_smb2_request_error_ex: smbd_smb2_request_error_ex: idx[1] status[NT_STATUS_OBJECT_NAME_NOT_FOUND] || at ../../source3/smbd/smb2_create.c:360 which weren't informing the admin know what was really wrong. This patch doesn't help, but it does avoid saying "smbd_smb2_request_error_ex" three times. REF: https://lists.samba.org/archive/samba/2025-February/250967.html Signed-off-by: Douglas Bagnall Reviewed-by: Jennifer Sutton Reviewed-by: Rowland Penny --- diff --git a/source3/smbd/smb2_server.c b/source3/smbd/smb2_server.c index 5c3b7b90dc9..3b692fdca87 100644 --- a/source3/smbd/smb2_server.c +++ b/source3/smbd/smb2_server.c @@ -4077,7 +4077,7 @@ NTSTATUS smbd_smb2_request_error_ex(struct smbd_smb2_request *req, uint8_t *outhdr = SMBD_SMB2_OUT_HDR_PTR(req); size_t unread_bytes = smbd_smb2_unread_bytes(req); - DBG_NOTICE("smbd_smb2_request_error_ex: idx[%d] status[%s] |%s| " + DBG_NOTICE("idx[%d] status[%s] |%s| " "at %s\n", req->current_idx, nt_errstr(status), info ? " +info" : "", location);