From: hno <>
Date: Wed, 3 May 2000 01:40:12 +0000 (+0000)
Subject: hno squid-2.2.STABLE4.aio_cond_segfault-2.patch
X-Git-Tag: SQUID_3_0_PRE1~2023
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=ff21eb3e4b6f6c843e59b68ecee0fa1cc49fe311;p=thirdparty%2Fsquid.git

hno squid-2.2.STABLE4.aio_cond_segfault-2.patch
Squid-2.2.STABLE4: Async-IO segfaults if AIO_PROPER_MUTEX isn't set

Async-IO on Linux segfaults in condition variables if given high load
and AIO_PROPER_MUTEX isn't set. This was seen on a SMP Alpha Linux
2.2.10-ac12 box. I knew there was a reason why I made the
AIO_PROPER_MUTEX code a long time ago..
[an incorrect version of this simple patch was already committed]
---

diff --git a/ChangeLog b/ChangeLog
index c08f8dd9ba..140bc0eca1 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -26,6 +26,9 @@ Changes to Squid-2.4.DEVEL3 ():
 	  rather than raw space, and platform support somewhat extended.
 	- Logs destination IP in the hierarchy log tag when going direct.
 	  (can be disabled by turning log_ip_on_direct off)
+	- Async-IO on linux now makes proper use of mutexes. This fixes some
+	  odd pthread segfaults on SMP Linux machines, at a slight performance
+	  penalty.
 
 Changes to Squid-2.4.DEVEL2 ():