From: Mike Brady <4265913+mikebrady@users.noreply.github.com>
Date: Mon, 19 Apr 2021 20:10:09 +0000 (+0100)
Subject: Add mickey mouse averaging. Seems to work very well.
X-Git-Tag: 1.1-dev~25
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=ff56f49ff0dde2f4eb53ba08097b96ed57a6ba06;p=thirdparty%2Fnqptp.git

Add mickey mouse averaging. Seems to work very well.
---

diff --git a/nqptp-clock-sources.h b/nqptp-clock-sources.h
index 52b6486..9f0d00d 100644
--- a/nqptp-clock-sources.h
+++ b/nqptp-clock-sources.h
@@ -47,6 +47,8 @@ typedef struct {
   uint32_t flags;
   uint16_t sequence_number;
   uint16_t in_use;
+  uint64_t mm_count; // mickey mouse averaging
+  uint64_t mm_average; // the mickey mouse average
   enum stage current_stage;
   uint64_t t1, t2, t3, previous_offset, previous_estimated_offset;
   // for garbage collection
diff --git a/nqptp-message-handlers.c b/nqptp-message-handlers.c
index 75fbcea..c55b4e8 100644
--- a/nqptp-message-handlers.c
+++ b/nqptp-message-handlers.c
@@ -126,6 +126,8 @@ void handle_control_port_messages(char *buf, ssize_t recv_len,
             t = create_clock_source_record(new_ip, clock_private_info);
 
           // if it is just about to become a timing peer, reset its sample count
+          // since we don't know what was going on beforehand
+          clock_private_info[t].mm_count = 0;
           clock_private_info[t].vacant_samples = MAX_TIMING_SAMPLES;
           clock_private_info[t].next_sample_goes_here = 0;
 
@@ -428,7 +430,7 @@ void handle_follow_up(char *buf, __attribute__((unused)) ssize_t recv_len,
 }
 
 void handle_delay_resp(char *buf, __attribute__((unused)) ssize_t recv_len,
-                       clock_source_private_data *clock_private_info, uint64_t reception_time) {
+                       clock_source_private_data *clock_private_info, __attribute__ ((unused)) uint64_t reception_time) {
   struct ptp_delay_resp_message *msg = (struct ptp_delay_resp_message *)buf;
 
   if ((clock_private_info->current_stage == follow_up_seen) &&
@@ -479,6 +481,22 @@ void handle_delay_resp(char *buf, __attribute__((unused)) ssize_t recv_len,
       if (clock_private_info->vacant_samples > 0)
         clock_private_info->vacant_samples--;
 
+
+      // do the mickey mouse averaging
+      if (clock_private_info->mm_count == 0) {
+        clock_private_info->mm_average = offset;
+        clock_private_info->mm_count = 1;
+      } else {
+        if (clock_private_info->mm_count < 5000)
+          clock_private_info->mm_count++;
+        clock_private_info->mm_average = (clock_private_info->mm_count - 1) * (clock_private_info->mm_average / clock_private_info->mm_count) ;
+        clock_private_info->mm_average = clock_private_info->mm_average + (1.0 * offset) / clock_private_info->mm_count;
+      }
+      uint64_t estimated_offset = (uint64_t)clock_private_info->mm_average;
+
+/*
+      // do real averaging
+
       int sample_count = MAX_TIMING_SAMPLES - clock_private_info->vacant_samples;
       int64_t divergence = 0;
       uint64_t estimated_offset = offset;
@@ -495,6 +513,7 @@ void handle_delay_resp(char *buf, __attribute__((unused)) ssize_t recv_len,
         offsets = offsets / sample_count;
         estimated_offset = (uint64_t)offsets;
       }
+*/
 
       clock_private_info->previous_estimated_offset = estimated_offset;
 
@@ -503,6 +522,7 @@ void handle_delay_resp(char *buf, __attribute__((unused)) ssize_t recv_len,
       clock_private_info->local_time = clock_private_info->t2;
       clock_private_info->local_to_source_time_offset = estimated_offset;
 
+      // debug(1,"mm_average: %" PRIx64 ", estimated_offset: %" PRIx64 ".", mm_average_int, estimated_offset);
       if ((clock_private_info->flags & (1 << clock_is_master)) != 0) {
         update_master_clock_info(clock_private_info->clock_id, clock_private_info->local_time,
                                  clock_private_info->local_to_source_time_offset);