From: cyeh%bluemartini.com <>
Date: Tue, 22 Aug 2000 03:16:00 +0000 (+0000)
Subject: fix for #39044 : Some vers. of some browsers give a script warning on query page... 
X-Git-Tag: bugzilla-2.12~205
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=ff85006b3da36c24439c87f016aafe3317347ef0;p=thirdparty%2Fbugzilla.git

fix for #39044 : Some vers. of some browsers give a script warning on query page when not
using milestones. patch submitted by nkiesel@tbdnetworks.com
---

diff --git a/query.cgi b/query.cgi
index 9253073c2b..c42c01afe3 100755
--- a/query.cgi
+++ b/query.cgi
@@ -431,40 +431,41 @@ function selectProduct(f) {
         }
     }
 
-    var tmsel = new Array();
-    for (i=0 ; i<f.target_milestone.length ; i++) {
-        if (f.target_milestone[i].selected) {
-            tmsel[f.target_milestone[i].value] = 1;
+    if (f.target_milestone) {
+        var tmsel = new Array();
+        for (i=0 ; i<f.target_milestone.length ; i++) {
+            if (f.target_milestone[i].selected) {
+                tmsel[f.target_milestone[i].value] = 1;
+            }
         }
-    }
-
-    f.target_milestone.options.length = 0;
-
-    for (tm in tms) {
-        if (typeof(tms[v]) == 'function') continue;
-        var doit = doall;
-        for (i=0 ; !doit && i<f.product.length ; i++) {
-            if (f.product[i].selected) {
-                var p = f.product[i].value;
-                for (j in tms[tm]) {
-                    if (typeof(tms[tm][j]) == 'function') continue;
-                    var p2 = tms[tm][j];
-                    if (p2 == p) {
-                        doit = true;
-                        break;
+    
+        f.target_milestone.options.length = 0;
+    
+        for (tm in tms) {
+            if (typeof(tms[v]) == 'function') continue;
+            var doit = doall;
+            for (i=0 ; !doit && i<f.product.length ; i++) {
+                if (f.product[i].selected) {
+                    var p = f.product[i].value;
+                    for (j in tms[tm]) {
+                        if (typeof(tms[tm][j]) == 'function') continue;
+                        var p2 = tms[tm][j];
+                        if (p2 == p) {
+                            doit = true;
+                            break;
+                        }
                     }
                 }
             }
-        }
-        if (doit) {
-            var l = f.target_milestone.length;
-            f.target_milestone[l] = new Option(tm, tm);
-            if (tmsel[tm]) {
-                f.target_milestone[l].selected = true;
+            if (doit) {
+                var l = f.target_milestone.length;
+                f.target_milestone[l] = new Option(tm, tm);
+                if (tmsel[tm]) {
+                    f.target_milestone[l].selected = true;
+                }
             }
         }
     }
-
 }
 // -->
 </script>