From: Alan T. DeKok Date: Wed, 17 May 2017 16:03:46 +0000 (-0400) Subject: check sizeof(*packet). Found by PVS-Studio X-Git-Tag: release_3_0_14~17 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=ffa424d138611d2e7ed57b217a899d0c2009ae74;p=thirdparty%2Ffreeradius-server.git check sizeof(*packet). Found by PVS-Studio --- diff --git a/src/modules/rlm_eap/types/rlm_eap_pwd/rlm_eap_pwd.c b/src/modules/rlm_eap/types/rlm_eap_pwd/rlm_eap_pwd.c index 9abae5c80a5..3c043f72846 100644 --- a/src/modules/rlm_eap/types/rlm_eap_pwd/rlm_eap_pwd.c +++ b/src/modules/rlm_eap/types/rlm_eap_pwd/rlm_eap_pwd.c @@ -386,8 +386,8 @@ static int mod_process(void *arg, eap_handler_t *handler) } packet = (pwd_id_packet_t *) in; - if (in_len < sizeof(packet)) { - RDEBUG("Packet is too small (%zd < %zd).", in_len, sizeof(packet)); + if (in_len < sizeof(*packet)) { + RDEBUG("Packet is too small (%zd < %zd).", in_len, sizeof(*packet)); return 0; }