From: Willy Tarreau Date: Tue, 2 Apr 2013 21:16:53 +0000 (+0200) Subject: BUG/MAJOR: http: fix regression introduced by commit a890d072 X-Git-Tag: v1.5-dev18~31 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=ffb6f08babe3252c73995d1c7f2fba096fa7b370;p=thirdparty%2Fhaproxy.git BUG/MAJOR: http: fix regression introduced by commit a890d072 This commit fixed a bug and introduced a new one at the same time. It's a stupid typo, the index to store the context is [0], not [2]. The effect is that parsing the header can loop forever if multiple headers are found. This issue was reported by Lukas Tribus. --- diff --git a/src/proto_http.c b/src/proto_http.c index e7d84ce951..311268f1be 100644 --- a/src/proto_http.c +++ b/src/proto_http.c @@ -8673,7 +8673,7 @@ smp_fetch_hdr(struct proxy *px, struct session *l4, void *l7, unsigned int opt, /* first call */ ctx = &static_hdr_ctx; ctx->idx = 0; - smp->ctx.a[2] = ctx; + smp->ctx.a[0] = ctx; } if (args) {