From: NeilBrown <neilb@suse.de>
Date: Thu, 18 Sep 2008 06:03:08 +0000 (+1000)
Subject: Don't allow spares when creating 'external' arrays.
X-Git-Tag: mdadm-3.0-devel1~9
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=ffcfc735a5114290cb6b3063c8a5fddddc384a36;p=thirdparty%2Fmdadm.git

Don't allow spares when creating 'external' arrays.

It is meaningless when creating the container, and for
subarrays, the container is responsible for assigning
spares.

Also, don't do the 'spare' fiddle for raid5 as we cannot
set up a spare at this point yet.  Later maybe just create
the array degraded and let the container sort it out.
---

diff --git a/Create.c b/Create.c
index 652bc1c7..7a4a81df 100644
--- a/Create.c
+++ b/Create.c
@@ -166,6 +166,12 @@ int Create(struct supertype *st, char *mddev, int mdfd,
 			devlist = NULL;
 		}
 	}
+	if (st && st->ss->external && sparedisks) {
+		fprintf(stderr,
+			Name ": This metadata type does not support "
+			"spare disks are create time\n");
+		return 1;
+	}
 	if (subdevs > raiddisks+sparedisks) {
 		fprintf(stderr, Name ": You have listed more devices (%d) than are in the array(%d)!\n", subdevs, raiddisks+sparedisks);
 		return 1;
@@ -411,6 +417,7 @@ int Create(struct supertype *st, char *mddev, int mdfd,
 	 * into a spare, else the create will fail
 	 */
 	if (assume_clean == 0 && force == 0 && first_missing < raiddisks &&
+	    st->ss->external == 0 &&
 	    second_missing >= raiddisks && level == 6) {
 		insert_point = raiddisks - 1;
 		if (insert_point == first_missing)