From: Juergen Perlinger <perlinger@ntp.org>
Date: Thu, 10 Oct 2019 13:26:29 +0000 (+0200)
Subject: [Bug 3620] memory leak in ntpq sysinfo
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=ffd6d7f77f0c7b360c58974d32f2e4665bdcf874;p=thirdparty%2Fntp.git

[Bug 3620] memory leak in ntpq sysinfo

bk: 5d9f3185qq-g1S4npf-YHHRlucu1lA
---

diff --git a/ChangeLog b/ChangeLog
index d5a490cdc..04c546658 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -2,6 +2,8 @@
 
 * [Sec 3610] process_control() should bail earlier on short packets. stenn@
   - Reported by Philippe Antoine
+* [Bug 3620] memory leak in ntpq sysinfo <perlinger@ntp.org>
+  - applied patch by Gerry Garvey
 * [Bug 3619] Honour drefid setting in cooked mode and sysinfo <perlinger@ntp.org>
   - applied patch by Gerry Garvey
 * [Bug 3615] accelerate refclock startup <perlinger@ntp.org>
diff --git a/ntpq/ntpq-subs.c b/ntpq/ntpq-subs.c
index ecb1428bc..3020cc5c2 100644
--- a/ntpq/ntpq-subs.c
+++ b/ntpq/ntpq-subs.c
@@ -3874,12 +3874,16 @@ collect_display_vdc(
 			atouint(pvdc->v.str, &ul);
 			xprintf(fp, "%s  %s\n", pvdc->display,
 				modetoa((int)ul));
+			free(pvdc->v.str);
+			pvdc->v.str = NULL;
 			break;
 
 		case NTP_2BIT:
 			atouint(pvdc->v.str, &ul);
 			xprintf(fp, "%s  %s\n", pvdc->display,
 				leapbits[ul & 0x3]);
+			free(pvdc->v.str);
+			pvdc->v.str = NULL;
 			break;
 
 		case NTP_REFID: