From: Willy Tarreau <w@1wt.eu>
Date: Tue, 26 May 2026 06:24:04 +0000 (+0200)
Subject: BUG/MINOR: sample: request an extra output byte for the url_dec converter
X-Git-Tag: v3.4-dev14~35
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=ffdc91c4a19a589f23eabb6df0ad6075802949fb;p=thirdparty%2Fhaproxy.git

BUG/MINOR: sample: request an extra output byte for the url_dec converter

A dynamic chunk size is now being allocated for output since commit
dfc4085413 ("MEDIUM: sample: Get chunks with a size dependent on input
data when necessary"). However this one missed the need for the trailing
zero when specifying the size, let's add it.

No backport is needed, this is only in 3.4.
---

diff --git a/src/http_conv.c b/src/http_conv.c
index a46432dc0..c0a2f9536 100644
--- a/src/http_conv.c
+++ b/src/http_conv.c
@@ -263,7 +263,7 @@ static int sample_conv_url_dec(const struct arg *args, struct sample *smp, void
 	  * before decoding.
 	 */
 	if (smp->flags & SMP_F_CONST || smp->data.u.str.size <= smp->data.u.str.data) {
-		struct buffer *str = get_trash_chunk_sz(smp->data.u.str.data);
+		struct buffer *str = get_trash_chunk_sz(smp->data.u.str.data + 1);
 
 		if (!str)
 			return 0;