From: Sean Bright <sean@malleable.com>
Date: Thu, 18 Sep 2014 19:29:30 +0000 (+0000)
Subject: res_pjsip: Don't require a password when doing userpass authentication.
X-Git-Tag: 12.6.0-rc1~7
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=ffe70619136d10d5445c560acf2e70f6d9ff183d;p=thirdparty%2Fasterisk.git

res_pjsip: Don't require a password when doing userpass authentication.

An empty password is valid for username/password authentication so we should
allow password to be empty/not supplied.

Review: https://reviewboard.asterisk.org/r/3988


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/12@423481 65c4cc65-6c06-0410-ace0-fbb531ad65f3
---

diff --git a/res/res_pjsip/config_auth.c b/res/res_pjsip/config_auth.c
index e105e7492a..30af0ef03e 100644
--- a/res/res_pjsip/config_auth.c
+++ b/res/res_pjsip/config_auth.c
@@ -94,13 +94,6 @@ static int auth_apply(const struct ast_sorcery *sorcery, void *obj)
 	}
 
 	switch (auth->type) {
-	case AST_SIP_AUTH_TYPE_USER_PASS:
-		if (ast_strlen_zero(auth->auth_pass)) {
-			ast_log(LOG_ERROR, "'userpass' authentication specified but no "
-					"password specified for auth '%s'\n", ast_sorcery_object_get_id(auth));
-			res = -1;
-		}
-		break;
 	case AST_SIP_AUTH_TYPE_MD5:
 		if (ast_strlen_zero(auth->md5_creds)) {
 			ast_log(LOG_ERROR, "'md5' authentication specified but no md5_cred "
@@ -113,6 +106,7 @@ static int auth_apply(const struct ast_sorcery *sorcery, void *obj)
 			res = -1;
 		}
 		break;
+	case AST_SIP_AUTH_TYPE_USER_PASS:
 	case AST_SIP_AUTH_TYPE_ARTIFICIAL:
 		break;
 	}