From: Joshua Colp <jcolp@digium.com>
Date: Tue, 26 Apr 2016 10:48:40 +0000 (-0300)
Subject: app_queue: Fix crash when unloading module.
X-Git-Tag: 14.0.0-beta1~231
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=refs%2Fchanges%2F05%2F2705%2F2;p=thirdparty%2Fasterisk.git

app_queue: Fix crash when unloading module.

When unloading the app_queue module the members in each queue are
destroyed and as part of this they are removed from the pending
members container. Unfortunately a crash would occur as the container
was destroyed before the members were removed.

This change tweaks ordering so the container destruction occurs
after the members are destroyed.

ASTERISK-16115

Change-Id: I48c728668c55aee3d05b751a5d450fb57e87f44b
---

diff --git a/apps/app_queue.c b/apps/app_queue.c
index 927c4967ec..8171d11cb4 100644
--- a/apps/app_queue.c
+++ b/apps/app_queue.c
@@ -10983,8 +10983,9 @@ static int unload_module(void)
 	ast_extension_state_del(0, extension_state_cb);
 
 	ast_unload_realtime("queue_members");
-	ao2_cleanup(pending_members);
 	ao2_cleanup(queues);
+	ao2_cleanup(pending_members);
+
 	queues = NULL;
 	return 0;
 }