From: Vladimír Čunát <vladimir.cunat@nic.cz>
Date: Mon, 12 Aug 2024 08:57:11 +0000 (+0200)
Subject: NEWS+comment for the parent commit
X-Git-Tag: v6.0.9~35^2
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=refs%2Fenvironments%2Fdocs-develop-fix-gakq6a%2Fdeployments%2F4847;p=thirdparty%2Fknot-resolver.git

NEWS+comment for the parent commit
---

diff --git a/NEWS b/NEWS
index e8ba52303..92ebe3062 100644
--- a/NEWS
+++ b/NEWS
@@ -10,11 +10,14 @@ Improvements
   The secret is created automatically if the user does not configure their own secret in the configuration.
   This means that the workers will be able to resume each other's TLS sessions, regardless of whether the user has configured it to do so.
 
+- answer NOTIMPL for meta-types and non-IN RR classes (!1589)
+
 Bugfixes
 --------
 
 - daemon/proxyv2: fix informing the engine about TCP/TLS from the actual client (!1578)
 
+
 Knot Resolver 6.0.8 (2024-07-23)
 ================================
 
diff --git a/lib/layer/iterate.c b/lib/layer/iterate.c
index c6f9ec976..3cc641cd8 100644
--- a/lib/layer/iterate.c
+++ b/lib/layer/iterate.c
@@ -927,6 +927,7 @@ static int begin(kr_layer_t *ctx)
 		knot_pkt_t *ans = kr_request_ensure_answer(ctx->req);
 		if (!ans)
 			return ctx->req->state;
+		/* This RCODE is explicitly suggested for meta QTYPEs in RFC 8906 sec.7 */
 		knot_wire_set_rcode(ans->wire, KNOT_RCODE_NOTIMPL);
 		kr_request_set_extended_error(ctx->req, KNOT_EDNS_EDE_NOTSUP, "57CK");
 		return KR_STATE_DONE;