From: Vladimír Čunát <vladimir.cunat@nic.cz>
Date: Mon, 2 Jun 2025 12:42:01 +0000 (+0200)
Subject: lib/rules: drop FIXMEs
X-Git-Tag: v6.0.14~1^2
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=refs%2Fenvironments%2Fdocs-local-data-r-ozywnc%2Fdeployments%2F6930;p=thirdparty%2Fknot-resolver.git

lib/rules: drop FIXMEs

These don't need resolving, as the return values for kr_* functions
didn't change really in the end.
---

diff --git a/lib/rules/api.c b/lib/rules/api.c
index 8078de715..82e3ee769 100644
--- a/lib/rules/api.c
+++ b/lib/rules/api.c
@@ -47,7 +47,6 @@ static const uint8_t KEY_VIEW_SRC6[1] = "6";
 
 
 /// Returns for functions below: RET_ANSWERED, RET_CONTINUE, negative error codes for bugs
-// FIXME: doc-comment for kr_rule_local_data_answer(), etc.
 enum ret_codes_ {
 	RET_CONT_CACHE = 0,
 	RET_ANSWERED = 1,
diff --git a/lib/rules/api.h b/lib/rules/api.h
index b2e11dd11..7e972dde3 100644
--- a/lib/rules/api.h
+++ b/lib/rules/api.h
@@ -98,7 +98,7 @@ int kr_rules_reset(void);
 
 /** Try answering the query from local data; WIP: otherwise determine data source overrides.
  *
- * \return kr_error() on errors, >0 if answered FIXME, 0 otherwise (also when forwarding)
+ * \return kr_error() on errors, >0 if answered, 0 otherwise (also when forwarding)
  *
  * FIXME: we probably want to ensure AA flags in answer as appropriate.
  *   Perhaps approach it like AD?  Tweak flags in ranked_rr_array_entry