From: Nick Porter <nick@portercomputing.co.uk>
Date: Tue, 27 Jan 2026 10:23:48 +0000 (+0000)
Subject: Pacify Coverity (CID #1680659 and #1680658)
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=refs%2Fheads%2Fdeveloper%2Fndptech;p=thirdparty%2Ffreeradius-server.git

Pacify Coverity (CID #1680659 and #1680658)

Coverity doesn't appear to look inside state_entry_create to see that it
leaves the mutex unlocked on failure.
---

diff --git a/src/lib/server/state.c b/src/lib/server/state.c
index 68f3b016244..ccdb6204107 100644
--- a/src/lib/server/state.c
+++ b/src/lib/server/state.c
@@ -868,6 +868,14 @@ int fr_state_store(fr_state_tree_t *state, request_t *request)
 	if (!entry) {
 		talloc_free(request_state_replace(request, state_ctx));
 		request_data_restore(request, &data);	/* Put it back again */
+
+#ifdef __COVERITY__
+		/*
+		 *  Coverity doesn't see that state_entry_create releases
+		 *  the lock on failure
+		 */
+		PTHREAD_MUTEX_UNLOCK(&state->mutex)
+#endif
 		return -1;
 	}