From: Tobias Stoeckmann <tobias@stoeckmann.org>
Date: Fri, 9 Jan 2026 16:49:39 +0000 (+0100)
Subject: su: Use exit instead of _exit in kill_child
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=refs%2Fheads%2Fmaster;p=thirdparty%2Fshadow.git

su: Use exit instead of _exit in kill_child

Since this is no signal handler anymore, allow regular exit routine to
flush stderr etc.

Reviewed-by: Alejandro Colomar <alx@kernel.org>
Reviewed-by: Ruihan Li <lrh2000@pku.edu.cn>
Signed-off-by: Tobias Stoeckmann <tobias@stoeckmann.org>
---

diff --git a/src/su.c b/src/su.c
index 7cf203b50..dfbfc3c57 100644
--- a/src/su.c
+++ b/src/su.c
@@ -172,7 +172,7 @@ kill_child(pid_t pid_child)
 {
 	kill(-pid_child, SIGKILL);
 	fputs(_(" ...killed.\n"), stderr);
-	_exit (255);
+	exit (255);
 }
 
 static void
@@ -402,7 +402,7 @@ static void prepare_pam_close_session (void)
 		if (sigprocmask (SIG_BLOCK, &ourset, NULL) != 0) {
 			fprintf (stderr, _("%s: signal masking malfunction\n"), Prog);
 			kill_child(pid_child);
-			/* Never reached (_exit called). */
+			/* Never reached (exit called). */
 		}
 
 		/* Send SIGKILL to the child if it doesn't
@@ -418,7 +418,7 @@ static void prepare_pam_close_session (void)
 			sigsuspend (&ourset);
 			if (timeout) {
 				kill_child(pid_child);
-				/* Never reached (_exit called). */
+				/* Never reached (exit called). */
 			}
 		}
 		pid_child = 0;