From: Stefano Lattarini <stefano.lattarini@gmail.com>
Date: Wed, 7 Jan 2015 10:59:03 +0000 (+0100)
Subject: [ng] tests: fix spurious failure due to non-POSIX shells
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=refs%2Fheads%2Fng%2Fmaster;p=thirdparty%2Fautomake.git

[ng] tests: fix spurious failure due to non-POSIX shells

Seen on, e.g., Solaris 10.

* t/internals.tap: Here, by making sure a POSIX shell is used to
run the recipe in the Makefiles running our unit tests.

Signed-off-by: Stefano Lattarini <stefano.lattarini@gmail.com>
---

diff --git a/t/internals.tap b/t/internals.tap
index eede9748f..cc997c308 100644
--- a/t/internals.tap
+++ b/t/internals.tap
@@ -37,11 +37,17 @@ T ()
   cd T$i.d
   {
     echo 'include ../defn.mk'
+    # Make sure $(shell ...) invocations use a POSIX shell -- /bin/sh is
+    # borked and non-POSIX on a few systems, most notably Solaris 10.
+    # That has already caused spurious failures in the past.
+    echo "SHELL = ${SHELL}"
     echo 'lower = abcdefghijklmnopqrstuvwxyz'
     echo 'upper = ABCDEFGHIJKLMNOPQRSTUVWXYZ'
     echo 'digits = 0123456789'
+    # The rest of the makefile come from the standard input passed to this
+    # function.
+    cat
   } > Makefile
-  cat >> Makefile
   test_name=$1; shift
   command_ok_ "$test_name" $MAKE ${1+"$@"} test
   cd ..