From: Ján Tomko <jtomko@redhat.com>
Date: Fri, 14 Jun 2019 07:16:14 +0000 (+0200)
Subject: api: disallow virConnectGetDomainCapabilities on read-only connections
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=refs%2Fheads%2Fv1.2.20-maint;p=thirdparty%2Flibvirt.git

api: disallow virConnectGetDomainCapabilities on read-only connections

This API can be used to execute arbitrary emulators.
Forbid it on read-only connections.

Fixes: CVE-2019-10167
Signed-off-by: Ján Tomko <jtomko@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
(cherry picked from commit 8afa68bac0cf99d1f8aaa6566685c43c22622f26)
Signed-off-by: Ján Tomko <jtomko@redhat.com>
---

diff --git a/src/libvirt-domain.c b/src/libvirt-domain.c
index 0303da6b04..b8e9e1e473 100644
--- a/src/libvirt-domain.c
+++ b/src/libvirt-domain.c
@@ -11118,6 +11118,7 @@ virConnectGetDomainCapabilities(virConnectPtr conn,
     virResetLastError();
 
     virCheckConnectReturn(conn, NULL);
+    virCheckReadOnlyGoto(conn->flags, error);
 
     if (conn->driver->connectGetDomainCapabilities) {
         char *ret;