From: Luca Bruno <lethalman88@gmail.com>
Date: Tue, 1 Jun 2010 20:06:17 +0000 (+0200)
Subject: Deprecate use of += and -= for signals
X-Git-Tag: 0.9.1~3
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=refs%2Fkeep-around%2Fc353329b280f945d6d8188af5817ae44723d6e1d;p=thirdparty%2Fvala.git

Deprecate use of += and -= for signals

The connect/disconnect methods should be used instead.

Fixes bug 617571.
---

diff --git a/vala/valaassignment.vala b/vala/valaassignment.vala
index 77725663a..5833e6be4 100644
--- a/vala/valaassignment.vala
+++ b/vala/valaassignment.vala
@@ -164,7 +164,13 @@ public class Vala.Assignment : Expression {
 
 			if (ma.symbol_reference is DynamicSignal) {
 				// target_type not available for dynamic signals
+				if (!analyzer.context.deprecated) {
+					Report.warning (source_reference, "deprecated syntax, use `connect' method instead");
+				}
 			} else if (ma.symbol_reference is Signal) {
+				if (!analyzer.context.deprecated) {
+					Report.warning (source_reference, "deprecated syntax, use `connect' method instead");
+				}
 				var sig = (Signal) ma.symbol_reference;
 				right.target_type = new DelegateType (sig.get_delegate (ma.inner.value_type, this));
 			} else {