From: Štěpán Balážik <stepan.balazik@nic.cz>
Date: Thu, 4 Feb 2021 15:58:51 +0000 (+0100)
Subject: iterate.c: remove STRICT_MODE for good
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=refs%2Fpipelines%2F76175;p=thirdparty%2Fknot-resolver.git

iterate.c: remove STRICT_MODE for good

Removing this workaround actually causes Deckard scenarios to fail
(namely iter_escape_bailiwick.rpl) so I conclude that it is needed.
---

diff --git a/lib/layer/iterate.c b/lib/layer/iterate.c
index 8ea7b7f4c..0a09a9006 100644
--- a/lib/layer/iterate.c
+++ b/lib/layer/iterate.c
@@ -254,16 +254,12 @@ static int update_cut(knot_pkt_t *pkt, const knot_rrset_t *rr,
 	if (!ok) {
 		VERBOSE_MSG("<= authority: ns outside bailiwick\n");
 		qry->server_selection.error(qry, req->upstream.transport, KR_SELECTION_LAME_DELEGATION);
-#ifdef STRICT_MODE
-		return KR_STATE_FAIL;
-#else
 		/* Workaround: ignore out-of-bailiwick NSs for authoritative answers,
 		 * but fail for referrals. This is important to detect lame answers. */
 		if (knot_pkt_section(pkt, KNOT_ANSWER)->count == 0) {
 			state = KR_STATE_FAIL;
 		}
 		return state;
-#endif
 	}
 
 	/* Update zone cut name */